Skip to content

Add test examples for regional targetProxies to resources google_network_services_tls_route#16747

Open
rostislavbobo wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
rostislavbobo:tlsroute-target-tcp-proxy-global
Open

Add test examples for regional targetProxies to resources google_network_services_tls_route#16747
rostislavbobo wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
rostislavbobo:tlsroute-target-tcp-proxy-global

Conversation

@rostislavbobo
Copy link
Member

@rostislavbobo rostislavbobo commented Mar 17, 2026 •
edited
Loading

Add test examples for regional targetProxies to the TlsRoute resource. The targetProxies field itself was added to the TLSRoute resource in #16768

Fixes hashicorp/terraform-provider-google#26490

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@rostislavbobo rostislavbobo mentioned this pull request Mar 19, 2026
Merged
5 tasks
@rostislavbobo rostislavbobo force-pushed the tlsroute-target-tcp-proxy-global branch from 1b5c5eb to 8265751 Compare March 20, 2026 00:39
@rostislavbobo rostislavbobo changed the title Add field targetProxies to resources google_network_services_tls_route (beta) Add test examples for regional targetProxies to resources google_network_services_tls_route Mar 20, 2026
@rostislavbobo rostislavbobo marked this pull request as ready for review March 20, 2026 00:50
@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 104 insertions(+))
google-beta provider: Diff ( 4 files changed, 248 insertions(+))

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from NickElliot March 20, 2026 00:50
@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 104 insertions(+))
google-beta provider: Diff ( 4 files changed, 248 insertions(+))

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

Tests analytics

Total tests: 1492
Passed tests: 1393
Skipped tests: 96
Affected tests: 3

Click here to see the affected service packages
  • compute
  • networkservices

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample
  • TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample
  • TestAccNetworkServicesTlsRoute_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

🟢 Tests passed during RECORDING mode:
TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample [Debug log]
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesTlsRoute_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

Tests analytics

Total tests: 1492
Passed tests: 1393
Skipped tests: 96
Affected tests: 3

Click here to see the affected service packages
  • compute
  • networkservices

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample
  • TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample
  • TestAccNetworkServicesTlsRoute_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

🟢 Tests passed during RECORDING mode:
TestAccComputeTargetTcpProxy_targetTcpProxyTlsRouteExample [Debug log]
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteTargetTcpProxyBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesTlsRoute_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@rostislavbobo
Copy link
Member Author

rostislavbobo commented Mar 20, 2026

Hi @NickElliot , the failed tests are unrelated to this PR and fixed with #16771. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickElliot NickElliot Awaiting requested review from NickElliot

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

service/compute-l7-load-balancer service/networkservices-traffic-director

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Terraform support for TLSRoute for global Target TCP Proxies (beta)

2 participants

@rostislavbobo @modular-magician